diff --git a/Lib/test/test_minidom.py b/Lib/test/test_minidom.py index 3ecd1af31eea77..bfd35369577d48 100644 --- a/Lib/test/test_minidom.py +++ b/Lib/test/test_minidom.py @@ -396,13 +396,28 @@ def testChangeAttr(self): dom.unlink() def testGetAttrList(self): - pass + dom = parseString("") + self.addCleanup(dom.unlink) + el = dom.documentElement + el.setAttribute("spam", "jam") + self.assertEqual(len(el.attributes.items()), 1) + el.setAttribute("foo", "bar") + items = el.attributes.items() + self.assertEqual(len(items), 2) + self.assertIn(('spam', 'jam'), items) + self.assertIn(('foo', 'bar'), items) def testGetAttrValues(self): - pass - - def testGetAttrLength(self): - pass + dom = parseString("") + self.addCleanup(dom.unlink) + el = dom.documentElement + el.setAttribute("spam", "jam") + values = [x.value for x in el.attributes.values()] + self.assertIn("jam", values) + el.setAttribute("foo", "bar") + values = [x.value for x in el.attributes.values()] + self.assertIn("bar", values) + self.assertIn("jam", values) def testGetAttribute(self): dom = Document() @@ -496,8 +511,6 @@ def testAttributeRepr(self): self.confirm(str(node) == repr(node)) dom.unlink() - def testTextNodeRepr(self): pass - def testWriteXML(self): str = '' dom = parseString(str) @@ -601,9 +614,19 @@ def testProcessingInstruction(self): and pi.localName is None and pi.namespaceURI == xml.dom.EMPTY_NAMESPACE) - def testProcessingInstructionRepr(self): pass + def testProcessingInstructionRepr(self): + dom = parseString('') + pi = dom.documentElement.firstChild + self.assertEqual(str(pi.nodeType), repr(pi.nodeType)) - def testTextRepr(self): pass + def testTextRepr(self): + dom = Document() + self.addCleanup(dom.unlink) + elem = dom.createElement("elem") + elem.appendChild(dom.createTextNode("foo")) + el = elem.firstChild + self.assertEqual(str(el), repr(el)) + self.assertEqual('', str(el)) def testWriteText(self): pass