-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Windows pdb while capturing is broken since 2.8.6 #1388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
there indeed ws an issue fixed by #1281 @embray @nicoddemus can you verify the problem @temp4746 is seeing independently? @temp4746 can you take a look if it happens with the latest python of the 2.7 series |
It's possible this is a different but related issue, since the bug I fixed actually caused an infinite output of Python tracebacks, rather than just a frozen prompt. But it's entirely possible more work is needed (though I suspect it's more an issue with pyreadline than with pytest). |
Oops sorry I missed this. I will try to reproduce the problem tonight. |
Sorry for not replying earlier! I couldn't reproduce it here:
Here's my environment:
(I also tried with Could you post similar information about your environment @temp4746? |
Reproduced on a clean virtualenv (Python 2.7.11) with the following only:
Using this test file (Named test.py): def test_x():
assert False Running py.test like this: |
@temp4746 sorry but I still can't reproduce it in my home computer... which shell are you using? Plain I will try to reproduce this tomorrow at work. |
Plain old cmd.exe (Note that I'm using Windows 7 so not the revamped cmd.exe in Windows 10) |
Hmmm at home I'm using Windows 10 (cmd.exe was revamped in Windows 10? Didn't notice 😜) I completely forgot to try this at work, I use Windows 7 in there. Will try this tomorrow (for real this time). |
Hmmm I could reproduce this in Windows 7... not sure when I will be able to tackle it though. |
Win7 x64, py.test 2.9.2, pyreadline 2.1, python 2.7.10 x32. Have the same problem. Tried to comment line with _readline_workaround() in the _pytest/capture.py:pytest_load_initial_conftests and it works for me now, I have possibility to work with py.tests and PDB. It seems that I miss something important, but I haven't noticed it yet) |
Weird. So #1281 fixes pdb for some people, but breaks it for others? |
Same conclusion as @maliavko for me: commenting out Windows 7 x64, regular cmd.exe console, Python 3.5.1, pytest-2.9.2, py-1.4.31, pluggy-0.3.1 |
Same issue. If it can help anyone, another workaround (without modifying source) would be to use temporarily sys level capturing: Windows 7 x64, regular cmd.exe console, Python 2.7.12 (anaconda), pytest-3.0.2 |
Same issue for me (although I swear it worked once, in a virtualenv, but I just can't remember which!). the workaround by @zadamah works for me, and instead of
My system:
thanks for creating such awesome free software! ❤️ |
Closing this issue as both Python 2 and Windows 7 have passed their end-of-life dates. |
While running py.test with --pdb and pyreadline installed once the pdb pops up no input can be entered. The prompt is non-responsive.
This seems related to the fix related to pyreadline that was added. Commenting out the
import readline
makes this work again.Maybe the fix that was added is also dependent on the Python version used, the behaviour of readline initialization in Python might be different. Or maybe this fix fixed a different bug with pyreadline integration.
Python 2.7.8, pyreadline 2.1, py.test 2.8.7
The text was updated successfully, but these errors were encountered: