Skip to content

Commit 489f6f4

Browse files
committedNov 1, 2020
unittest: fix quadratic behavior in collection of unittests using setUpClass/setup_method
This is similar to 50114d4; I missed that unittest does the same thing.
1 parent a95da7a commit 489f6f4

File tree

2 files changed

+19
-1
lines changed

2 files changed

+19
-1
lines changed
 

‎bench/unit_test.py

+13
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
from unittest import TestCase # noqa: F401
2+
3+
for i in range(15000):
4+
exec(
5+
f"""
6+
class Test{i}(TestCase):
7+
@classmethod
8+
def setUpClass(cls): pass
9+
def test_1(self): pass
10+
def test_2(self): pass
11+
def test_3(self): pass
12+
"""
13+
)

‎src/_pytest/unittest.py

+6-1
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,12 @@ def _make_xunit_fixture(
119119
if setup is None and teardown is None:
120120
return None
121121

122-
@pytest.fixture(scope=scope, autouse=True)
122+
@pytest.fixture(
123+
scope=scope,
124+
autouse=True,
125+
# Use a unique name to speed up lookup.
126+
name=f"unittest_{setup_name}_fixture_{obj.__qualname__}",
127+
)
123128
def fixture(self, request: FixtureRequest) -> Generator[None, None, None]:
124129
if _is_skipped(self):
125130
reason = self.__unittest_skip_why__

0 commit comments

Comments
 (0)