Merge pull request #11492 from ret2libc/raise-file-parse-error-no-valueerr

Raise RequirementsFileParseError when missing closing quotation

Author: pfmoore

news/11491.bugfix.rst

@@ -0,0 +1 @@
+Raise RequirementsFileParseError when parsing malformed requirements options that can't be sucessfully parsed by shlex.

src/pip/_internal/req/req_file.py

@@ -393,7 +393,12 @@ def parse_line(line: str) -> Tuple[str, Values]:
 
         args_str, options_str = break_args_options(line)
 
-        opts, _ = parser.parse_args(shlex.split(options_str), defaults)
+        try:
+            options = shlex.split(options_str)
+        except ValueError as e:
+            raise OptionParsingError(f"Could not split options: {options_str}") from e
+
+        opts, _ = parser.parse_args(options, defaults)
 
         return args_str, opts
 

tests/unit/test_req_file.py

@@ -786,6 +786,20 @@ def test_req_file_parse_comment_start_of_line(
 
         assert not reqs
 
+    def test_invalid_options(self, tmpdir: Path, finder: PackageFinder) -> None:
+        """
+        Test parsing invalid options such as missing closing quotation
+        """
+        with open(tmpdir.joinpath("req1.txt"), "w") as fp:
+            fp.write("--'data\n")
+
+        with pytest.raises(RequirementsFileParseError):
+            list(
+                parse_reqfile(
+                    tmpdir.joinpath("req1.txt"), finder=finder, session=PipSession()
+                )
+            )
+
     def test_req_file_parse_comment_end_of_line_with_url(
         self, tmpdir: Path, finder: PackageFinder
     ) -> None: