Skip to content

Commit 409d3a2

Browse files
authored
Merge branch 'main' into xrowan/test_profiling
2 parents 7ec8cc2 + 415cb80 commit 409d3a2

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

econml/tests/test_shap.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,9 @@ def eta_sample(n):
181181

182182
# test shap could generate the plot from the shap_values
183183
heatmap(shap_values1["Y0"]["orange"], show=False)
184-
waterfall(shap_values1["Y0"]["orange"][6], show=False)
184+
if shap.__version__ != "0.40.0":
185+
# waterfall is broken in this version, fixed by https://github.com/slundberg/shap/pull/2444
186+
waterfall(shap_values1["Y0"]["orange"][6], show=False)
185187
scatter(shap_values1["Y0"]["orange"][:, "A"], show=False)
186188
bar(shap_values1["Y0"]["orange"], show=False)
187189
beeswarm(shap_values1["Y0"]["orange"], show=False)

setup.cfg

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ install_requires =
3939
joblib >= 0.13.0
4040
statsmodels >= 0.10
4141
pandas
42-
shap >= 0.38.1, < 0.40.0
42+
shap >= 0.38.1, < 0.41.0
4343
dowhy < 0.8
4444
lightgbm
4545
test_suite = econml.tests

0 commit comments

Comments
 (0)