Merge pull request #2785 from qinyang912/master

FIX postInsert hook not working when use bulkInsert to insert doc

Author: pubkey

src/rx-collection.ts

@@ -419,7 +419,6 @@ export class RxCollectionBase<
                     const startTime = now();
                     return this.pouch.bulkDocs(insertDocs)
                         .then(results => {
-                            const endTime = now();
                             const okResults = results.filter(r => r.ok);
 
                             // create documents
@@ -430,6 +429,20 @@ export class RxCollectionBase<
                                 return doc;
                             });
 
+                            return Promise.all(
+                                rxDocuments.map(doc => {
+                                    return this._runHooks(
+                                        'post',
+                                        'insert',
+                                        docsMap.get(doc.primary),
+                                        doc
+                                    );
+                                })
+                            ).then(() => {
+                                return { rxDocuments, errorResults: results.filter(r => !r.ok) };
+                            });
+                        }).then(({ rxDocuments, errorResults }) => {
+                            const endTime = now();
                             // emit events
                             rxDocuments.forEach(doc => {
                                 const emitEvent = createInsertEvent(
@@ -444,7 +457,7 @@ export class RxCollectionBase<
 
                             return {
                                 success: rxDocuments,
-                                error: results.filter(r => !r.ok)
+                                error: errorResults
                             };
                         });
                 }

test/unit/hooks.test.ts

@@ -180,6 +180,19 @@ config.parallel('hooks.test.js', () => {
                     assert.strictEqual(count, 1);
                     c.database.destroy();
                 });
+                it('should call post insert hook after bulkInsert', async () => {
+                    const c = await humansCollection.create(0);
+                    const human = schemaObjects.human();
+                    let count = 0;
+                    c.postInsert((data, instance) => {
+                        assert.ok(data.age);
+                        assert.ok(isRxDocument(instance));
+                        count++;
+                    }, false);
+                    await c.bulkInsert([human]);
+                    assert.strictEqual(count, 1);
+                    c.database.destroy();
+                });
             });
         });
     });