-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation Error Regarding Email Verification Link Failed #3349
Comments
Hey @Harshit-7373 Can I work on this one or is the issue already solved |
@thunish Yes, you can contribute to this issue. It's currently open and has not been solved yet. You can provide translations for all the languages you know, ensuring that the translations are 100% accurate. |
Hey @Harshit-7373, I have create a pr for this issue, could you please review it and let me know for any further modifications |
@thunish Most of the changes are correct, but I noticed that you added a file for the Telugu translation , you dont have to, the files are already created with all the languages involved in the p5.js web editor. Also, I mentioned in the PR that the translations for "English, Hindi, French, Portuguese, and Korean" have already been corrected—you only needed to make changes for the remaining languages. Additionally, I suggest making changes only for the languages you are confident about and can assure are 100% correct. This will help prevent any incorrect translations from being merged into the main website. |
@raclim Please review his PR once. He has updated the translations for all the languages. I told him to make changes only for the languages he knows. If you could share your thoughts here, that would be helpful. |
@Harshit-7373 sorry for that, I thought adding another language would be helpful, I am sure that I have not made changes to files |
@thunish All the languages used in the p5.js web editor are mentioned in the website's navbar. You can cross-check from there and make changes. There is no need to add any new languages at the moment. |
@Harshit-7373 Thank you for the clarification! I understand now that all supported languages are already listed in the p5.js web editor, and there’s no need to add new ones. I’ll go through the existing translations again and ensure that I only make changes for the languages I’m confident about. Let me know if there’s anything else I should adjust! |
@thunish I looked into your PR and noticed that you had added a language but later removed it. However, there is still a file named (i18n.js) where you have added "te," which I assume was for that language. Also, changing translations for all languages is not a beneficial approach; you should only modify those you are familiar with. Additionally, p5.js does not rely solely on machine translations, as native speakers vet and verify them as well. @raclim I will verify the translation changes for the languages I know and will update you accordingly. |
@raclim I Know Bengali, and the changes made in the PR by @Harshit-7373 are correct. This PR is ready to be merged. |
Thanks @Harshit-7373 and @Arjun83-png for your input! Please feel free @thunish to resubmit with the updated changes! |
p5.js version
No response
What is your operating system?
Mac OS
Web browser and version
No response
Actual Behavior
If the token is invalid, the error message displayed is "Something Went Wrong."
When the language is set to English, Hindi, French, Portuguese, or Korean, the error message is displayed correctly.
Expected Behavior
The error message should be more descriptive and state "The token is invalid or expired."
For all other languages not mentioned above, the error message should also be correctly displayed.
Steps to reproduce
Steps:
Snippet:
// Paste your code here :)
The text was updated successfully, but these errors were encountered: