-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSX type definition in Preact 8 is moved into preact namespace or JSX type definition is added to global for compatibility #1811
Comments
So uhh which one are you asking for? global was removed because it conflicted with react |
JSX is added to global. Or JSX in Preact 8 is moved into preact namespace. |
I think it is better that JSX type definition in Preact 8 is moved into preact namespace. |
Release in v8.5.0 |
Great, now porting my 8.x preact app to 10 breaks my toolchain because "JSX element implicitly has type 'any' because no interface 'JSX.IntrinsicElements' exists". My app uses JavaScript with TS 3.5 only to enable |
In 8.4.x, JSX exists in global namespace. |
The namespace of JSX was changed.
This is breaking change.
I think that it is better to specify in the release notes.
preact/src/index.d.ts
Lines 6 to 8 in b4e059a
preact/src/preact.d.ts
Lines 168 to 170 in 3aaa578
To solve the following issue, I think that it is better to add JSX type definition to global.
developit/unistore#158
I think it is better that JSX type definition in global be deprecated.
The text was updated successfully, but these errors were encountered: