Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: move css-inline pkg to extra group #634

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rich-iannone
Copy link
Member

Given that css-inline does not work with pyodide and is really only ever used in as_raw_html(), this PR makes this library and optional dependency. It's placed in the 'extra' optional install group (along with packages for other export functions like save()).

Fixes: #567

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.18%. Comparing base (7174974) to head (1cf8ac4).

Files with missing lines Patch % Lines
great_tables/_export.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
- Coverage   91.18%   91.18%   -0.01%     
==========================================
  Files          47       47              
  Lines        5459     5458       -1     
==========================================
- Hits         4978     4977       -1     
  Misses        481      481              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rich-iannone rich-iannone marked this pull request as ready for review March 7, 2025 18:28
@rich-iannone rich-iannone requested a review from machow as a code owner March 7, 2025 18:28
@github-actions github-actions bot temporarily deployed to pr-634 March 7, 2025 18:32 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

css-inline requirement breaks shinylive
1 participant