Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rust-lang/rust
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: pnkfelix/rust
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: figure-out-testing-strategy-for-pr-108996
Choose a head ref
Can’t automatically merge. Don’t worry, you can still create the pull request.
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Mar 14, 2023

  1. the sketch of a test -- but does not yet work to expose bug on my mac… 

    …hine locally.
    @pnkfelix
    pnkfelix committed Mar 14, 2023
    Copy the full SHA
    6536df1 View commit details

  2. try to fix how Makefile is selected solely for wasm32-unknown-unknown… 

    … target.
    @pnkfelix
    pnkfelix committed Mar 14, 2023
    Copy the full SHA
    98ae92a View commit details

  3. DO NOT CHECK IN. temporarily adding wasm32 to try build set to see if… 

    … my current run-make test works to catch failure in CI.
    @pnkfelix
    pnkfelix committed Mar 14, 2023
    Copy the full SHA
    238bf32 View commit details
Showing with 15 additions and 0 deletions.
  1. +3 −0 .github/workflows/ci.yml
  2. +3 −0 src/ci/github-actions/ci.yml
  3. +8 −0 tests/run-make/wasm-override-linker/Makefile
  4. +1 −0 tests/run-make/wasm-override-linker/foo.rs
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
@@ -62,6 +62,9 @@ jobs:
tidy: false
os: ubuntu-20.04-xl
env: {}
- name: wasm32
os: ubuntu-20.04-xl
env: {}
timeout-minutes: 600
runs-on: "${{ matrix.os }}"
steps:
3 changes: 3 additions & 0 deletions src/ci/github-actions/ci.yml
View file
Original file line number Diff line number Diff line change
@@ -308,6 +308,9 @@ jobs:
<<: *job-linux-xl
tidy: false

- name: wasm32
<<: *job-linux-xl

auto:
permissions:
actions: write # for rust-lang/simpleinfra/github-actions/cancel-outdated-builds
8 changes: 8 additions & 0 deletions tests/run-make/wasm-override-linker/Makefile
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
include ../../run-make-fulldeps/tools.mk

ifeq ($(TARGET),wasm32-unknown-unknown)
all:
$(RUSTC) foo.rs --crate-type cdylib --target wasm32-unknown-unknown -C linker=clang
else
all:
endif
1 change: 1 addition & 0 deletions tests/run-make/wasm-override-linker/foo.rs
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
// empty file