Skip to content

Commit fe90d7d

Browse files
committedAug 1, 2023
Auto merge of rust-lang#113854 - klensy:aarch64-msvc-remove-hack, r=Mark-Simulacrum
aarch64-msvc: remove CI hack for bad Windows SDK version This removes hack which manually replaced windows sdk version, as it looks like useless now, as CI uses newer version: https://github.com/rust-lang-ci/rust/actions/runs/5596259246/jobs/10233070602#step:24:929 `C:\Program Files (x86)\Windows Kits\10\include\10.0.22621.0\ucrt\corecrt_io.h` (look at version) related rust-lang#88796 It's nice to have some way to assert bad version, but i don't see anything except checking env rust-lang/cc-rs#646

File tree

3 files changed

+0
-9
lines changed

3 files changed

+0
-9
lines changed
 

‎.github/workflows/ci.yml

-1
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,6 @@ jobs:
418418
RUST_CONFIGURE_ARGS: "--build=x86_64-pc-windows-msvc --host=aarch64-pc-windows-msvc --enable-full-tools --enable-profiler"
419419
SCRIPT: python x.py dist bootstrap --include-default-paths
420420
DIST_REQUIRE_ALL_TOOLS: 1
421-
WINDOWS_SDK_20348_HACK: 1
422421
os: windows-2019-8core-32gb
423422
- name: dist-i686-mingw
424423
env:

‎src/ci/github-actions/ci.yml

-3
Original file line numberDiff line numberDiff line change
@@ -663,9 +663,6 @@ jobs:
663663
--enable-profiler
664664
SCRIPT: python x.py dist bootstrap --include-default-paths
665665
DIST_REQUIRE_ALL_TOOLS: 1
666-
# Hack around this SDK version, because it doesn't work with clang.
667-
# See https://github.com/rust-lang/rust/issues/88796
668-
WINDOWS_SDK_20348_HACK: 1
669666
<<: *job-windows-8c
670667

671668
- name: dist-i686-mingw

‎src/ci/scripts/install-clang.sh

-5
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,6 @@ if isMacOS; then
3939
ciCommandSetEnv AR "ar"
4040
elif isWindows && [[ ${CUSTOM_MINGW-0} -ne 1 ]]; then
4141

42-
if [[ ${WINDOWS_SDK_20348_HACK-0} -eq 1 ]]; then
43-
rm -rf '/c/Program Files (x86)/Windows Kits/10/include/10.0.20348.0'
44-
mv '/c/Program Files (x86)/Windows Kits/10/include/'10.0.{19041,20348}.0
45-
fi
46-
4742
# If we're compiling for MSVC then we, like most other distribution builders,
4843
# switch to clang as the compiler. This'll allow us eventually to enable LTO
4944
# amongst LLVM and rustc. Note that we only do this on MSVC as I don't think

0 commit comments

Comments
 (0)
Please sign in to comment.