Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate transforms in v2 #5652

Closed
archmoj opened this issue May 11, 2021 · 7 comments · Fixed by #5657
Closed

Deprecate transforms in v2 #5652

archmoj opened this issue May 11, 2021 · 7 comments · Fixed by #5657

Comments

@archmoj
Copy link
Contributor

archmoj commented May 11, 2021

We should remove transforms from the bundles but keep a way to re-include them.

@nicolaskruchten
Copy link
Contributor

Let's hold off on this one until we can talk about it next week

@nicolaskruchten
Copy link
Contributor

I think we should not change anything, because we have not been advertising them as "deprecated" but we can start in v2. so I'll remove them from docs and we can mark those attributes as "deprecated" in the schema, but keep them in all the same places they are now bundle-wise

@archmoj
Copy link
Contributor Author

archmoj commented May 13, 2021

The transforms are a registered method (function) on the plotly API.
It appears we cannot "deprecate" transforms similar to other data attributes by putting it in a _deprecated container.
So I am wondering what is the expected behaviour for deprecating transforms?
Just changing the description similar to what we did for heatmapgl is enough?
Should Plotly.validate pass or it does not matter while there is #4759 bug?!

@nicolaskruchten
Copy link
Contributor

Yes, including some deprecation text in the schema attributes is enough for me.

@Domino987
Copy link
Contributor

@nicolaskruchten Hello, i was wondering why the transformers were deprecated and if there is a way to include a similar function (filtering data above a threshold) nativly with plotly?

There is of course the possibility to filter the data outside of plotly, but I would assume it could be faster to do it within the lib?

@chadamski
Copy link

@nicolaskruchten Hello, i was wondering why the transformers were deprecated and if there is a way to include a similar function (filtering data above a threshold) nativly with plotly?

There is of course the possibility to filter the data outside of plotly, but I would assume it could be faster to do it within the lib?

I'm also looking for some guidance on why transforms are being deprecated and what the recommended alternate method of handling will be.

@andoks
Copy link

andoks commented Nov 7, 2023

I would also like to know what alternatives there are to the transform functionality

Also I believe this relates to the deprecation notices change in the docs plotly/graphing-library-docs@8b334a9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants