Skip to content

commit plot-schema like a baseline? #5588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicolaskruchten opened this issue Apr 13, 2021 · 2 comments · Fixed by #5776
Closed

commit plot-schema like a baseline? #5588

nicolaskruchten opened this issue Apr 13, 2021 · 2 comments · Fixed by #5776
Labels
feature something new
Milestone

Comments

@nicolaskruchten
Copy link
Contributor

What if we treated the final plot schema like a baseline? You'd have to generate it and commit it in any PR that changes it, otherwise the build would fail, and then the review process would explicitly review the changes to the schema. This would catch situations where we add something to e.g. axes and it impacts axes in indicator, color bars etc etc.

@alexcjohnson thoughts? cam from a chat with @archmoj ... can discuss at the next meeting

@alexcjohnson
Copy link
Collaborator

Great idea! In our call today @archmoj and I discussed having the dev build process (npm start) generate a copy of the schema in the build folder, and committing that one, so that the version in dist stays in sync with the rest of the published files.

@nicolaskruchten
Copy link
Contributor Author

Oh yes the version in dist should stay in sync! build is still a bit nebulous for me, but it sure seems like a reasonable place for this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants