Skip to content

Handle symbol numbers in string format #4460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
archmoj opened this issue Jan 5, 2020 · 1 comment · Fixed by #5073
Closed

Handle symbol numbers in string format #4460

archmoj opened this issue Jan 5, 2020 · 1 comment · Fixed by #5073
Assignees
@archmoj
Labels
bug something broken feature something new

Comments

@archmoj
Copy link
Contributor

archmoj commented Jan 5, 2020

Demo
@etpinard etpinard added the feature something new label Jan 6, 2020
@archmoj archmoj added the bug something broken label Aug 6, 2020
@alexcjohnson
Copy link
Collaborator

I suspect this line:

plotly.js/src/components/drawing/index.js

Line 253 in 29b456e

if(typeof v === 'string') {

Just needs to be changed to if (!isNumeric(v)) {

@archmoj archmoj mentioned this issue Aug 13, 2020
Merged
1 task
@archmoj archmoj self-assigned this Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@archmoj archmoj

Labels
bug something broken feature something new
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accept symbol numbers in string format plotly/plotly.js
3 participants
@alexcjohnson @etpinard @archmoj