Skip to content

Additional aggregation functions: range and change #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bhogan-mitre opened this issue Jun 28, 2018 · 4 comments
Closed

Additional aggregation functions: range and change #2763

bhogan-mitre opened this issue Jun 28, 2018 · 4 comments
Labels
feature something new

Comments

@bhogan-mitre
Copy link
Contributor

I would like to use some additional, fairly simple, functions for aggregations. Per brief exchange on the community site, it seems like Plotly would be open to including more functions.

Two functions I would suggest are:

  • range: max - min
  • change: last - first
@etpinard etpinard added the feature something new label Jun 28, 2018
@alexcjohnson
Copy link
Collaborator

Sure, those both sound completely reasonable. Would you like to make a PR to add them? In addition to adding them as attribute values as you already mentioned in the community post, they just need to be added in getAggregateFunction and then included briefly in the aggregation test suite

@bhogan-mitre
Copy link
Contributor Author

Yes, I will try to put together a PR for this. Thanks for links to the other touch points for these functions!

@bhogan-mitre
Copy link
Contributor Author

PR into my own fork is linked above. Please let me know if you have any suggestions on this, @alexcjohnson. Thanks in advance.

@bhogan-mitre
Copy link
Contributor Author

Thanks for the review! Linked above is a PR into the main repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

No branches or pull requests

3 participants