Skip to content

Aitoff and sinusoidal geo projections #1400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
collioud opened this issue Feb 21, 2017 · 1 comment · Fixed by #1422
Closed

Aitoff and sinusoidal geo projections #1400

collioud opened this issue Feb 21, 2017 · 1 comment · Fixed by #1422
Assignees
Labels
feature something new

Comments

@collioud
Copy link

Hello,

I noticed by looking at the plotly.js file that two geo projections are already included : the aitoff and the sinusoidal one. But these are not directly usable because they are not referenced.
This could be done by adding the two following code lines into the plotly.js file :

// projection names to d3 function name
params.projNames = {
    // d3.geo.projection
    ...
    'aitoff': 'aitoff',           
    'sinusoidal': 'sinusoidal'   
};

Of course, the API reference should be also updated.

I am very pleased that these are already included since I need the aitoff projection for one project of mine. I didn't feel adding a projection "from scratch" into Plotly.js...

@etpinard etpinard added the feature something new label Feb 21, 2017
@etpinard
Copy link
Contributor

Ha good 👁️

The sinusoidal projection is indeed exported in our projections bundle but currently and mistekenly not exposed.

I don't think we ever planned on exposing the Aitoff projection, but as the popular Winkel Triplet projection depends on Aitoff, might as well expose it also.

Thanks for posting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants