Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit de65c44

Browse files
authoredJun 13, 2016
Merge pull request #626 from plotly/mapbox
Introducing plotly.js + Mapbox GL
2 parents 63e41e0 + df77966 commit de65c44

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+4427
-7
lines changed
 

‎CONTRIBUTING.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,18 @@ which shows the baseline image, the generated image, the diff and the json mocks
157157

158158
To view the results of a run on CircleCI, download the `build/test_images/` and `build/test_images_diff/` artifacts into your local repo and then run `npm run start-image_viewer`.
159159

160+
### Note on testing our `mapbox-gl` integration
161+
162+
Creating `mapbox-gl` graphs requires an
163+
[`accessToken`](https://www.mapbox.com/help/define-access-token/). To make sure
164+
that mapbox image and jasmine tests run properly, locate your Mapbox access
165+
token and run:
166+
167+
168+
```bash
169+
export MAPBOX_ACCESS_TOKEN="<your access token>" && npm run pretest
170+
```
171+
160172

161173
## Repo organization
162174

‎circle.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,13 @@ dependencies:
1515
- docker pull plotly/testbed:latest
1616
post:
1717
- npm run cibuild
18+
- npm run pretest
1819
- docker run -d --name mytestbed -v $PWD:/var/www/streambed/image_server/plotly.js -p 9010:9010 plotly/testbed:latest
1920
- sudo ./tasks/run_in_testbed.sh mytestbed "cp -f test/image/index.html ../server_app/index.html"
2021
- wget --server-response --spider --tries=8 --retry-connrefused http://localhost:9010/ping
2122
test:
2223
override:
23-
- sudo ./tasks/run_in_testbed.sh mytestbed "node test/image/compare_pixels_test.js"
24+
- sudo ./tasks/run_in_testbed.sh mytestbed "export CIRCLECI=1 && node test/image/compare_pixels_test.js"
2425
- sudo ./tasks/run_in_testbed.sh mytestbed "node test/image/export_test.js"
2526
- npm run citest-jasmine
2627
- npm run test-bundle

0 commit comments

Comments
 (0)
Please sign in to comment.