Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit c71d689

Browse files
committedJan 14, 2021
stop exporting d3 v3 to the API
- use strictD3 in jasmine tests - add strict d3 path to constants - flat domain_ref assets
1 parent 7d2559e commit c71d689

File tree

102 files changed

+950
-896
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

102 files changed

+950
-896
lines changed
 

‎devtools/image_viewer/viewer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
var fs = require('fs');
22
var path = require('path');
33

4-
var d3 = require('@plotly/d3');
4+
var d3Json = require('../../test/strict_d3').json;
55

66
var $plotlist = document.getElementById('plot-list');
77
var $toggles = document.getElementById('plot-toggles');
@@ -55,7 +55,7 @@ function createButton(imageName) {
5555
button.style.cursor = 'pointer';
5656

5757
button.addEventListener('click', function() {
58-
d3.json(dirMocks + imageName + '.json', function(err, mock) {
58+
d3Json(dirMocks + imageName + '.json', function(err, mock) {
5959
$toggles.style.display = 'block';
6060

6161
$images.style.display = 'block';

‎devtools/test_dashboard/devtools.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ var Fuse = require('fuse.js/dist/fuse.common.js');
66
var mocks = require('../../build/test_dashboard_mocks.json');
77
var credentials = require('../../build/credentials.json');
88
var Lib = require('@src/lib');
9-
var d3 = Plotly.d3;
9+
var d3 = require('../../test/strict_d3');
10+
var d3Json = d3.json;
1011

1112
require('./perf');
1213

@@ -59,7 +60,7 @@ var Tabs = {
5960
plotMock: function(mockName, id) {
6061
var mockURL = '/test/image/mocks/' + mockName + '.json';
6162

62-
d3.json(mockURL, function(err, fig) {
63+
d3Json(mockURL, function(err, fig) {
6364
Plotly.newPlot(Tabs.fresh(id), fig);
6465

6566
console.warn('Plotting:', mockURL);
@@ -69,7 +70,7 @@ var Tabs = {
6970
getMock: function(mockName, callback) {
7071
var mockURL = '/test/image/mocks/' + mockName + '.json';
7172

72-
d3.json(mockURL, function(err, fig) {
73+
d3Json(mockURL, function(err, fig) {
7374
if(typeof callback !== 'function') {
7475
window.mock = fig;
7576
} else {

0 commit comments

Comments
 (0)
Please sign in to comment.