Skip to content

Commit 564dff6

Browse files
committedFeb 8, 2018
stop filling new [] in pie defaults
1 parent 3178b2e commit 564dff6

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed
 

‎src/traces/pie/calc.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ module.exports = function calc(gd, trace) {
1818
var vals = trace.values;
1919
var hasVals = Array.isArray(vals) && vals.length;
2020
var labels = trace.labels;
21-
var colors = trace.marker.colors;
21+
var colors = trace.marker.colors || [];
2222
var cd = [];
2323
var fullLayout = gd._fullLayout;
2424
var colorWay = fullLayout.colorway;

‎src/traces/pie/defaults.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout
3434
var lineWidth = coerce('marker.line.width');
3535
if(lineWidth) coerce('marker.line.color');
3636

37-
var colors = coerce('marker.colors');
38-
if(!Array.isArray(colors)) traceOut.marker.colors = [];
37+
coerce('marker.colors');
3938

4039
coerce('scalegroup');
4140
// TODO: hole needs to be coerced to the same value within a scaleegroup

0 commit comments

Comments
 (0)