Skip to content

Commit 405b9ed

Browse files
authoredOct 31, 2019
Merge pull request #4323 from plotly/bump-point-cluster-3.1.8
Fix scattergl mising points plot and react
2 parents 742b83d + 902b084 commit 405b9ed

12 files changed

+247055
-68
lines changed
 

‎package-lock.json

+22-44
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -100,13 +100,13 @@
100100
"ndarray": "^1.0.18",
101101
"ndarray-fill": "^1.0.2",
102102
"ndarray-homography": "^1.0.0",
103-
"point-cluster": "^3.1.4",
103+
"point-cluster": "^3.1.8",
104104
"polybooljs": "^1.2.0",
105105
"regl": "^1.3.11",
106106
"regl-error2d": "^2.0.8",
107107
"regl-line2d": "^3.0.15",
108-
"regl-scatter2d": "^3.1.5",
109-
"regl-splom": "^1.0.7",
108+
"regl-scatter2d": "^3.1.7",
109+
"regl-splom": "^1.0.8",
110110
"right-now": "^1.0.0",
111111
"robust-orientation": "^1.1.3",
112112
"sane-topojson": "^4.0.0",

‎src/traces/scattergl/calc.js

+1-6
Original file line numberDiff line numberDiff line change
@@ -97,12 +97,7 @@ module.exports = function calc(gd, trace) {
9797
if(opts.line && !scene.line2d) scene.line2d = true;
9898
if((opts.errorX || opts.errorY) && !scene.error2d) scene.error2d = true;
9999
if(opts.text && !scene.glText) scene.glText = true;
100-
101-
// FIXME: organize it in a more appropriate manner, probably in sceneOptions
102-
// put point-cluster instance for optimized regl calc
103-
if(opts.marker) {
104-
opts.marker.snap = stash.tree || TOO_MANY_POINTS;
105-
}
100+
if(opts.marker) opts.marker.snap = len;
106101

107102
scene.lineOptions.push(opts.line);
108103
scene.errorXOptions.push(opts.errorX);
1.05 MB
Loading

0 commit comments

Comments
 (0)
Please sign in to comment.