Skip to content

Commit 262cd5f

Browse files
pionbotSean-Der
authored andcommitted
Update CI configs to v0.11.15
Update lint scripts and CI configs.
1 parent e607601 commit 262cd5f

File tree

3 files changed

+14
-11
lines changed

3 files changed

+14
-11
lines changed

.github/workflows/test.yaml

+3-3
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
uses: pion/.goassets/.github/workflows/test.reusable.yml@master
2424
strategy:
2525
matrix:
26-
go: ["1.22", "1.21"] # auto-update/supported-go-version-list
26+
go: ["1.23", "1.22"] # auto-update/supported-go-version-list
2727
fail-fast: false
2828
with:
2929
go-version: ${{ matrix.go }}
@@ -33,13 +33,13 @@ jobs:
3333
uses: pion/.goassets/.github/workflows/test-i386.reusable.yml@master
3434
strategy:
3535
matrix:
36-
go: ["1.22", "1.21"] # auto-update/supported-go-version-list
36+
go: ["1.23", "1.22"] # auto-update/supported-go-version-list
3737
fail-fast: false
3838
with:
3939
go-version: ${{ matrix.go }}
4040

4141
test-wasm:
4242
uses: pion/.goassets/.github/workflows/test-wasm.reusable.yml@master
4343
with:
44-
go-version: "1.22" # auto-update/latest-go-version
44+
go-version: "1.23" # auto-update/latest-go-version
4545
secrets: inherit

.golangci.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
# SPDX-FileCopyrightText: 2023 The Pion community <https://pion.ly>
22
# SPDX-License-Identifier: MIT
33

4+
run:
5+
timeout: 5m
6+
47
linters-settings:
58
govet:
69
enable:
@@ -48,7 +51,7 @@ linters:
4851
- goconst # Finds repeated strings that could be replaced by a constant
4952
- gocritic # The most opinionated Go source code linter
5053
- godox # Tool for detection of FIXME, TODO and other comment keywords
51-
- goerr113 # Golang linter to check the errors handling expressions
54+
- err113 # Golang linter to check the errors handling expressions
5255
- gofmt # Gofmt checks whether code was gofmt-ed. By default this tool runs with -s option to check for code simplification
5356
- gofumpt # Gofumpt checks whether code was gofumpt-ed.
5457
- goheader # Checks is file header matches to pattern
@@ -83,17 +86,14 @@ linters:
8386
- depguard # Go linter that checks if package imports are in a list of acceptable packages
8487
- containedctx # containedctx is a linter that detects struct contained context.Context field
8588
- cyclop # checks function and package cyclomatic complexity
86-
- exhaustivestruct # Checks if all struct's fields are initialized
8789
- funlen # Tool for detection of long functions
8890
- gocyclo # Computes and checks the cyclomatic complexity of functions
8991
- godot # Check if comments end in a period
9092
- gomnd # An analyzer to detect magic numbers.
91-
- ifshort # Checks that your code uses short syntax for if-statements whenever possible
9293
- ireturn # Accept Interfaces, Return Concrete Types
9394
- lll # Reports long lines
9495
- maintidx # maintidx measures the maintainability index of each function.
9596
- makezero # Finds slice declarations with non-zero initial length
96-
- maligned # Tool to detect Go structs that would take less memory if their fields were sorted
9797
- nakedret # Finds naked returns in functions greater than a specified function length
9898
- nestif # Reports deeply nested if statements
9999
- nlreturn # nlreturn checks for a new line before return and branch statements to increase code clarity

association_test.go

+7-4
Original file line numberDiff line numberDiff line change
@@ -3485,11 +3485,14 @@ func TestAssociation_OpenStreamAfterInternalClose(t *testing.T) {
34853485
a1, a2, err := createAssocs()
34863486
require.NoError(t, err)
34873487

3488-
a1.netConn.Close()
3489-
a2.netConn.Close()
3488+
require.NoError(t, a1.netConn.Close())
3489+
require.NoError(t, a2.netConn.Close())
34903490

3491-
a1.OpenStream(1, PayloadTypeWebRTCString)
3492-
a2.OpenStream(1, PayloadTypeWebRTCString)
3491+
_, err = a1.OpenStream(1, PayloadTypeWebRTCString)
3492+
require.NoError(t, err)
3493+
3494+
_, err = a2.OpenStream(1, PayloadTypeWebRTCString)
3495+
require.NoError(t, err)
34933496

34943497
require.NoError(t, a1.Close())
34953498
require.NoError(t, a2.Close())

0 commit comments

Comments
 (0)