Merge pull request #1582 from pi-hole/tweak/chown-config

Chown config file after writing (if root)

Author: DL6ER

src/config/toml_helper.c

@@ -60,6 +60,28 @@ void closeFTLtoml(FILE *fp)
 	if(fclose(fp) != 0)
 		log_err("Cannot close FTL's config file: %s", strerror(errno));
 
+	// Chown file if we are root
+	if(geteuid() == 0)
+	{
+		// Get UID and GID of user with name "pihole"
+		struct passwd *pwd = getpwnam("pihole");
+		if(pwd == NULL)
+		{
+			log_warn("Cannot get UID and GID of user pihole: %s", strerror(errno));
+		}
+		else
+		{
+			const uid_t pihole_uid = pwd->pw_uid;
+			const gid_t pihole_gid = pwd->pw_gid;
+			// Chown file to pihole user
+			if(chown(GLOBALTOMLPATH, pihole_uid, pihole_gid) != 0)
+				log_warn("Cannot chown "GLOBALTOMLPATH" to pihole:pihole (%u:%u): %s",
+					(unsigned int)pihole_uid, (unsigned int)pihole_gid, strerror(errno));
+			else
+				log_debug(DEBUG_CONFIG, "Chown-ed "GLOBALTOMLPATH" to pihole:pihole (%u:%u)",
+					(unsigned int)pihole_uid, (unsigned int)pihole_gid);
+		}
+	}
 	return;
 }