Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: petermattis/goid
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: petermattis/goid
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: attempt-to-run
Choose a head ref
Able to merge. These branches can be automatically merged.
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Aug 13, 2024

  1. Attempt to run tests on s390x,aarch64

    tamird committed Aug 13, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    a560dbe View commit details
Showing with 0 additions and 27 deletions.
  1. +0 −27 .github/workflows/go.yml
27 changes: 0 additions & 27 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
@@ -155,20 +155,6 @@ jobs:
# https://go.dev/doc/go1.19.
echo "S390X_RACE_SUPPORTED=1" >> "$GITHUB_OUTPUT"
fi
# Race detector binaries crash with:
#
# FATAL: ThreadSanitizer: unsupported VMA range
#
# See https://github.com/golang/go/issues/29948.
echo "ARM64_UNSUPPORTED_VMA_RANGE=1" >> "$GITHUB_OUTPUT"
# Race detector binaries crash with:
#
# ==17==ERROR: ThreadSanitizer failed to allocate 0x7f0000 (8323072) bytes at address 9000001a0000 (errno: 12)
#
# See https://github.com/golang/go/issues/67881.
echo "S390X_THREAD_SANITIZER_FAILED_TO_ALLOCATE=1" >> "$GITHUB_OUTPUT"
- name: Check that Get is inlined
if: |
!startsWith(matrix.go, 'gccgo-') &&
@@ -227,19 +213,6 @@ jobs:
go build -v -race ./...
go test -c -race -o goid.race.test ./...
- run: rm goid.race.test
if: |
!cancelled() &&
(steps.build_goid_race_test.outcome == 'success' || steps.build_goid_race_test_cross.outcome == 'success') &&
(
matrix.arch == 'aarch64' &&
steps.configure_environment.outputs.ARM64_RACE_SUPPORTED &&
steps.configure_environment.outputs.ARM64_UNSUPPORTED_VMA_RANGE
) || (
matrix.arch == 's390x' &&
steps.configure_environment.outputs.S390X_RACE_SUPPORTED &&
steps.configure_environment.outputs.S390X_THREAD_SANITIZER_FAILED_TO_ALLOCATE
)
- name: Run tests
if: |
!cancelled() &&