Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify buf and prost protobuf build systems #1867

Closed
1 task
avahowell opened this issue Jan 20, 2023 · 5 comments
Closed
1 task

Unify buf and prost protobuf build systems #1867

avahowell opened this issue Jan 20, 2023 · 5 comments
Assignees

Comments

@avahowell
Copy link
Contributor

Currently, we have two independent systems for building the penumbra protobufs:

  • buf- Buf provides a standalone protobuf build system and registry, and can autogenerate code (such as for the relayer).
  • prost- Rust protobuf implementation, which is what links all of our protobufs to our crates internally and generates the rust code we use internally.

Until #1860, these two systems functioned identically. However, we now want buf to include upstream libraries instead of vendoring them, to avoid causing namespace conflicts in our consumers (such as the relayer). #1860 accomplishes that. However, now the prost side of the build system is building from different dependencies than the buf side. This happens to be okay now, but in the future this will likely cause issues.

To fix this, we should:

@conorsch conorsch moved this to Future in Testnets Jan 27, 2023
@conorsch
Copy link
Contributor

@avahowell Optimistically adding this to testnet 43, given the priority of the relayer work you've been doing. If you disagree, please update the milestone!

@conorsch conorsch moved this from Future to Testnet 43: Leda in Testnets Jan 27, 2023
@conorsch
Copy link
Contributor

conorsch commented Feb 2, 2023

Work is ongoing, untangling the protobuf build story. @avahowell reports she's going strong on this front, but it'll slip to next testnet; unlikely to be merged by EOW.

@conorsch
Copy link
Contributor

conorsch commented Feb 9, 2023

For sanity's sake, let's deprioritize this ticket, and get @avahowell back into Rustlang for a bit. =)

@conorsch conorsch moved this from Testnet 43: Leda to Future in Testnets Feb 9, 2023
@conorsch
Copy link
Contributor

@hdevalence
Copy link
Member

Closing in favor of #2184

@hdevalence hdevalence closed this as not planned Won't fix, can't repro, duplicate, stale Mar 17, 2023
@github-project-automation github-project-automation bot moved this from Future to Testnet 49: Pasiphae in Testnets Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Testnet 49: Pasiphae
Development

No branches or pull requests

3 participants