-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify buf and prost protobuf build systems #1867
Comments
@avahowell Optimistically adding this to testnet 43, given the priority of the relayer work you've been doing. If you disagree, please update the milestone! |
Work is ongoing, untangling the protobuf build story. @avahowell reports she's going strong on this front, but it'll slip to next testnet; unlikely to be merged by EOW. |
For sanity's sake, let's deprioritize this ticket, and get @avahowell back into Rustlang for a bit. =) |
Cross-linking related work for visibility: |
Closing in favor of #2184 |
Currently, we have two independent systems for building the penumbra protobufs:
Until #1860, these two systems functioned identically. However, we now want
buf
to include upstream libraries instead of vendoring them, to avoid causing namespace conflicts in our consumers (such as the relayer). #1860 accomplishes that. However, now theprost
side of the build system is building from different dependencies than thebuf
side. This happens to be okay now, but in the future this will likely cause issues.To fix this, we should:
buf
module cache for dependencies (see https://docs.buf.build/bsr/overview#module-cache)The text was updated successfully, but these errors were encountered: