From 9be3026bbd9506b24fe941354a40eadb7e213875 Mon Sep 17 00:00:00 2001 From: Elliot DeNolf Date: Fri, 6 Dec 2024 02:27:10 -0500 Subject: [PATCH] ci: explicitly use ubuntu-24.04 instead of latest to ensure compat (#9786) The runner image `ubuntu-latest` image will be switching from Ubuntu 22.04 to Ubuntu 24.04 as specified in https://github.com/actions/runner-images/issues/10636. > Rollout will begin on December 5th and will complete on January 17th, 2025. Breaking changes Ubuntu 24.04 is ready to be the default version for the "ubuntu-latest" label in GitHub Actions and Azure DevOps. This PR moves us to explicitly use `ubuntu-24.04` to ensure compatibility and to allow explicit upgrades in the future. --- .github/workflows/label-on-change.yml | 12 ++++++------ .github/workflows/lock-issues.yml | 2 +- .github/workflows/main.yml | 20 ++++++++++---------- .github/workflows/post-release-templates.yml | 2 +- .github/workflows/post-release.yml | 4 ++-- .github/workflows/pr-title.yml | 4 ++-- .github/workflows/release-canary.yml | 2 +- .github/workflows/stale.yml | 2 +- .github/workflows/triage.yml | 6 +++--- 9 files changed, 27 insertions(+), 27 deletions(-) diff --git a/.github/workflows/label-on-change.yml b/.github/workflows/label-on-change.yml index 74710934b58..1075d468593 100644 --- a/.github/workflows/label-on-change.yml +++ b/.github/workflows/label-on-change.yml @@ -13,7 +13,7 @@ on: jobs: on-labeled-ensure-one-status: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 permissions: issues: write # Only run on issue labeled and if label starts with 'status:' @@ -49,7 +49,7 @@ jobs: } on-issue-close: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 permissions: issues: write if: github.event.action == 'closed' @@ -82,7 +82,7 @@ jobs: } on-issue-reopen: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 permissions: issues: write if: github.event.action == 'reopened' @@ -93,7 +93,7 @@ jobs: labels: 'status: needs-triage' on-issue-assigned: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 permissions: issues: write if: > @@ -106,11 +106,11 @@ jobs: labels: 'status: needs-triage' # on-pr-merge: - # runs-on: ubuntu-latest + # runs-on: ubuntu-24.04 # if: github.event.pull_request.merged == true # steps: # on-pr-close: - # runs-on: ubuntu-latest + # runs-on: ubuntu-24.04 # if: github.event_name == 'pull_request_target' && github.event.pull_request.merged == false # steps: diff --git a/.github/workflows/lock-issues.yml b/.github/workflows/lock-issues.yml index a03f10918fc..05427a307fd 100644 --- a/.github/workflows/lock-issues.yml +++ b/.github/workflows/lock-issues.yml @@ -11,7 +11,7 @@ permissions: jobs: lock_issues: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - name: Lock issues uses: dessant/lock-threads@v5 diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 58851e05d68..fc9c6cf843a 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -23,7 +23,7 @@ env: jobs: changes: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 permissions: pull-requests: read outputs: @@ -64,7 +64,7 @@ jobs: lint: if: > github.event_name == 'pull_request' && !contains(github.event.pull_request.title, 'no-lint') && !contains(github.event.pull_request.title, 'skip-lint') - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v4 with: @@ -85,7 +85,7 @@ jobs: build: needs: changes if: ${{ needs.changes.outputs.needs_build == 'true' }} - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v4 @@ -108,7 +108,7 @@ jobs: key: ${{ github.sha }}-${{ github.run_number }} tests-unit: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 needs: [changes, build] if: ${{ needs.changes.outputs.needs_tests == 'true' }} steps: @@ -135,7 +135,7 @@ jobs: NODE_OPTIONS: --max-old-space-size=8096 tests-int: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 needs: [changes, build] if: ${{ needs.changes.outputs.needs_tests == 'true' }} name: int-${{ matrix.database }} @@ -235,7 +235,7 @@ jobs: on_retry_command: pnpm clean:build && pnpm install --no-frozen-lockfile tests-e2e: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 needs: [changes, build] if: ${{ needs.changes.outputs.needs_tests == 'true' }} name: e2e-${{ matrix.suite }} @@ -352,7 +352,7 @@ jobs: # Build listed templates with packed local packages build-templates: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 needs: build strategy: matrix: @@ -431,7 +431,7 @@ jobs: pnpm runts scripts/build-template-with-local-pkgs.ts ${{ matrix.template }} $POSTGRES_URL tests-type-generation: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 needs: [changes, build] if: ${{ needs.changes.outputs.needs_tests == 'true' }} steps: @@ -461,7 +461,7 @@ jobs: all-green: name: All Green if: always() - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 needs: - lint - build @@ -475,7 +475,7 @@ jobs: publish-canary: name: Publish Canary - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 if: ${{ needs.all-green.result == 'success' && github.ref_name == 'main' }} needs: - all-green diff --git a/.github/workflows/post-release-templates.yml b/.github/workflows/post-release-templates.yml index 0a529de01a8..dd064258723 100644 --- a/.github/workflows/post-release-templates.yml +++ b/.github/workflows/post-release-templates.yml @@ -14,7 +14,7 @@ env: jobs: update_templates: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 permissions: contents: write pull-requests: write diff --git a/.github/workflows/post-release.yml b/.github/workflows/post-release.yml index a8a7420d4c6..80477e7a42a 100644 --- a/.github/workflows/post-release.yml +++ b/.github/workflows/post-release.yml @@ -19,7 +19,7 @@ env: jobs: post_release: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 if: ${{ github.event_name != 'workflow_dispatch' }} steps: - uses: actions/checkout@v4 @@ -38,7 +38,7 @@ jobs: 🚀 This is included in version {release_link} github-releases-to-discord: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 if: ${{ github.event_name != 'workflow_dispatch' }} steps: - name: Checkout diff --git a/.github/workflows/pr-title.yml b/.github/workflows/pr-title.yml index ddb7a92b6ff..11989bc5d2d 100644 --- a/.github/workflows/pr-title.yml +++ b/.github/workflows/pr-title.yml @@ -12,7 +12,7 @@ permissions: jobs: main: name: lint-pr-title - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: amannn/action-semantic-pull-request@v5 id: lint_pr_title @@ -107,7 +107,7 @@ jobs: label-pr-on-open: name: label-pr-on-open - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 if: github.event.action == 'opened' steps: - name: Tag with 2.x branch with v2 diff --git a/.github/workflows/release-canary.yml b/.github/workflows/release-canary.yml index f2a90d0d991..55d7e0b8569 100644 --- a/.github/workflows/release-canary.yml +++ b/.github/workflows/release-canary.yml @@ -14,7 +14,7 @@ jobs: name: release-canary-${{ github.ref_name }}-${{ github.sha }} permissions: id-token: write - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - name: Checkout uses: actions/checkout@v4 diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index b642a38e6c7..b7637ed3540 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -5,7 +5,7 @@ on: jobs: stale: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 permissions: issues: write pull-requests: write diff --git a/.github/workflows/triage.yml b/.github/workflows/triage.yml index 405c28c3cd4..a7d765a1031 100644 --- a/.github/workflows/triage.yml +++ b/.github/workflows/triage.yml @@ -18,7 +18,7 @@ permissions: jobs: debug-context: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - name: View context attributes uses: actions/github-script@v7 @@ -27,7 +27,7 @@ jobs: label-created-by: name: label-on-open - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - name: Tag with 'created-by' uses: actions/github-script@v7 @@ -88,7 +88,7 @@ jobs: triage: name: initial-triage if: github.event_name == 'issues' - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 steps: - uses: actions/checkout@v4 with: