Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help wanted with v1.0 feature additions #16

Closed
cbaker6 opened this issue Jul 26, 2020 · 10 comments
Closed

Help wanted with v1.0 feature additions #16

cbaker6 opened this issue Jul 26, 2020 · 10 comments

Comments

@cbaker6
Copy link
Contributor

cbaker6 commented Jul 26, 2020

We are gearing up for the v1.0 release and would like your assistance with adding features. The features to be added can be found in https://github.com/parse-community/Parse-Swift/projects/1

Many of the features to be added have counterparts in the Objective-C SDK and though they are not implemented the same, can provide some guidance on what's needed. The Objective-C SDK test cases are also useful understanding what needs to be tested for the features.

There are some examples of Parse-Swift unit tests here

If you decide to take one on, just submit a Pull Request and change it to "Draft" to let people know you are working on it.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Aug 3, 2020

We also need help documenting the public methods via markdown. This would be great for those who are new to Parse or those thinking of converting or using the Swift SDK for their new apps.

Some of the comments can be used from the obj-c SDK, but retrofitted for Swift:

The docs currently populate automatically when your PR is accepted. You can see the bare docs here: http://parseplatform.org/Parse-Swift/api/

@paulfreeman
Copy link

paulfreeman commented Oct 27, 2020

@cbaker6 I may be able to give a hand with the part of the docs relevant to my app in the near future. I plan to port an objective-c parse app to a full SwiftUI based package once Files upload support is in place and I should have completed my current workload in a week or two.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Oct 27, 2020

@paulfreeman are you thinking of porting the iOS docs? https://github.com/parse-community/docs/tree/gh-pages/_includes/ios that show up here: https://docs.parseplatform.org/ios/guide/

If so, that would be great! @TomWFox what's the best way to go about this? My guess would be to create a PR to the docs repo adding a "swift" folder and then copy any file being converted from ios to swift. Then convert the file by making the relevant changes to the Parse-Swift SDK (removing the objective-c code). If there's a better way to do it, feel free to let us know

@TomWFox
Copy link
Contributor

TomWFox commented Oct 27, 2020

@cbaker6 That sounds good to me. My PR to add a fluter guide should provide some direction in terms of the setup although I don't think I finished.

I wouldn't discourage any improvements being made if parts of the iOS guide seem poorly written etc but it will probably be much quicker to review if it's as direct a copy and paste as possible.

@paulfreeman or @cbaker6 give me a shout if you get started on the guide because I may try and get the setup done if I have some free time at some point.

@TomWFox TomWFox pinned this issue Dec 20, 2020
@vdkdamian
Copy link
Contributor

I'll give it a try to help porting Unit tests

@cbaker6
Copy link
Contributor Author

cbaker6 commented Dec 26, 2020

@novemTeam thanks for your interest in helping! Would you mind working on the CloudCode feature here?

Once you get started, let me know if you need help by submitting a PR with your code.

@vdkdamian
Copy link
Contributor

A few months ago, I started converting my Objective-C app to Swift, I used Parse so I am relying a lot on ParseSwift now.
I think it's in my advantage to help get ParseSwift launched.
Would be better if we got some more people on this.

I'll now take a look at it and let you know what I can do.

@cbaker6
Copy link
Contributor Author

cbaker6 commented Dec 26, 2020

There are also some features that are currently in the Parse-Swift SDK that don't have tests. This might be an easier place to start since you don't need to add the feature first. It's possible the features need some additions, but some look intact, just need testing. One of the feature sets that falls in this category are Mutation Operations, https://github.com/parse-community/Parse-Swift/tree/main/Sources/ParseSwift/Mutation%20Operations

The tests in Objective-C are here: FieldOperationTests FieldOperationDecoderTests

You can find what needs additional unit tests by looking at the codecov (files with a lower percentage needs more tests), https://codecov.io/gh/parse-community/Parse-Swift/tree/main/Sources/ParseSwift

@cbaker6 cbaker6 changed the title Help wanted for porting unit tests from Objective-c to Swift Help wanted with v1.0 feature additions Dec 30, 2020
@pmmlo
Copy link
Contributor

pmmlo commented Dec 31, 2020

@cbaker6 Is the idea to keep LiveQuery as a separate SDK or have it integrated into Parse-Swift?

@cbaker6
Copy link
Contributor Author

cbaker6 commented Jan 1, 2021

Since it shouldn’t need any dependencies and the code needed to enable LiveQuery shouldn’t be large, it will most likely be integrated

@dplewis dplewis unpinned this issue Jan 20, 2021
@cbaker6 cbaker6 closed this as completed Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants