Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make reth-storage-api independent of db crates #14362

Closed
mattsse opened this issue Feb 10, 2025 · 0 comments · Fixed by #14540
Closed

Make reth-storage-api independent of db crates #14362

mattsse opened this issue Feb 10, 2025 · 0 comments · Fixed by #14540
Assignees
@mattsse
Labels
A-dependencies Pull requests or issues that are about dependencies C-enhancement New feature or request

Comments

@mattsse
Copy link
Collaborator

mattsse commented Feb 10, 2025

Describe the feature

ref #14356

we currently pull in:

reth/crates/storage/storage-api/Cargo.toml

Line 26 in 47bc55b

reth-trie-db.workspace = true

this should be reworked so that storage-api no longer depends on any reth db internals

Additional context

No response
@mattsse mattsse added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Feb 10, 2025
@mattsse mattsse added A-dependencies Pull requests or issues that are about dependencies and removed S-needs-triage This issue needs to be labelled labels Feb 10, 2025
@mattsse mattsse self-assigned this Feb 10, 2025
This was referenced Feb 11, 2025
Merged
Open
This was referenced Feb 17, 2025
Merged
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattsse mattsse

Labels
A-dependencies Pull requests or issues that are about dependencies C-enhancement New feature or request
Projects
Reth Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(db): move mod tables to db-api paradigmxyz/reth
1 participant
@mattsse