Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit warning log if http APIs are specified on CLI, but --http is not passed #11357

Closed
Rjected opened this issue Sep 30, 2024 · 0 comments · Fixed by #11360
Closed

Emit warning log if http APIs are specified on CLI, but --http is not passed #11357

Rjected opened this issue Sep 30, 2024 · 0 comments · Fixed by #11360
Labels
A-cli Related to the reth CLI A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@Rjected
Copy link
Member

Rjected commented Sep 30, 2024

Right now if we pass --http.api but not --http:

reth node --http.api eth,debug,admin

Then the node starts up but does not expose an http endpoint:

Active Internet connections (only servers)
Proto Recv-Q Send-Q Local Address           Foreign Address         State       PID/Program name
tcp        0      0 0.0.0.0:30303           0.0.0.0:*               LISTEN      1534005/reth
tcp        0      0 127.0.0.1:9001          0.0.0.0:*               LISTEN      1534005/reth
tcp        0      0 127.0.0.1:8551          0.0.0.0:*               LISTEN      1534005/reth
udp        0      0 0.0.0.0:30303           0.0.0.0:*                           1534005/reth

A warning should be emitted if this happens, notifying the user that they need to pass --http to expose the APIs

@Rjected Rjected added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-observability Related to tracing, metrics, logs and other observability tools A-cli Related to the reth CLI labels Sep 30, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Reth Tracker Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI A-observability Related to tracing, metrics, logs and other observability tools C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant