German buttons translation missing (and some others).

[sfadschm]

Expected behaviour

Everything should be translated.

Actual behaviour

The Local folder string and e.g., buttons in the add sync dialog are not translated (see screenshots).
I checked transiflex but everything seems to be translated there (and was working before 2.9).
Tested with both the use default language setting and specifically selecting Deutsch.

Client configuration

Client version: 2.9.0

Operating system: Windows 10 (up-to-date)

OS language: German

Screenshots

[fmoc]

Such buttons are standard within Qt. You won't be able to find them on Transifex, because the translations should be provided by Qt as well.

What's really strange is that the "Auswählen..." button is translated, because it's also a standard button. ll check the dialog's definition.

[fmoc]

I've checked how that dialog is set up. We use QWizard as a "frame" widget, the pages are four widgets we define in src/gui/wizard.

I don't see why there should be an inconsistency between the buttons on the bottom and the buttons on the wizard page.

[TheOneRing]

@fmoc do we successfully load the qtbase translations?

[fmoc]

I can't tell, really. We try a couple of different locations, but there is no logging in place that could tell us if the last call in the chain fails:

client/src/gui/application.cpp

Lines 731 to 738 in c7cf661

	const QString qtBaseTrFile = QLatin1String("qtbase_") + lang;
	if (!qtTranslator->load(qtTrFile, qtTrPath)) {
	if (!qtTranslator->load(qtTrFile, trPath)) {
	if (!qtTranslator->load(qtBaseTrFile, qtTrPath)) {
	qtTranslator->load(qtBaseTrFile, trPath);
	}
	}
	}

Edit: also, both strings "Auswählen" and "Next" should be part of qtbase. Why in the world should one half work while the other wouldn't?

[fmoc]

Can be reproduced in a Windows 10 VM.

[TheOneRing]

#9062

[gabi18]

Confirmed on Windows 10 20H2, client 2.9.1rc1 (build 5270) that the buttons are translated: