Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not abort sync on unavailable federated shares #7375

Open
ckamm opened this issue Aug 12, 2019 · 2 comments
Open

Do not abort sync on unavailable federated shares #7375

ckamm opened this issue Aug 12, 2019 · 2 comments
Labels
p3-medium Normal priority type:bug
Milestone

Comments

@ckamm
Copy link
Contributor

ckamm commented Aug 12, 2019

From #5088:

If there's a federated share but the source server is unavailable, the server will reply 503 with something like this:

<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\DAV\Exception\ServiceUnavailable</s:exception>
  <s:message>Storage is temporarily not available</s:message>
</d:error>

Currently the client assumes 503 with Sabre\DAV\Exception\ServiceUnavailable means maintenance mode. That's not a correct assumption for this case.

It can't rely on the "s:message" string, since it's translated. The client should request status.php to check for maintenance mode before continuing.

Test criteria: Unavailable federated shares don't cause the sync run to abort. Alll other files should be synced normally, only the share should be marked with an error.

@ckamm ckamm added type:bug p3-medium Normal priority labels Aug 12, 2019
@ckamm ckamm added this to the 2.6.1 milestone Aug 12, 2019
@michaelstingl
Copy link
Contributor

@ckamm Needs also to be fixed on the ownCloud server or in Sabre\DAV?

/cc @DeepDiver1975 @PVince81 @micbar

@ckamm
Copy link
Contributor Author

ckamm commented Aug 12, 2019

No, I don't think so. The client using this response to detect maintenance mode was a workaround/hack. It should check the existing API for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-medium Normal priority type:bug
Projects
None yet
Development

No branches or pull requests

4 participants