Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause Sync button terminates the syncing #10231

Closed
2 tasks done
bishwasojha opened this issue Nov 4, 2022 · 5 comments · Fixed by #10529
Closed
2 tasks done

Pause Sync button terminates the syncing #10231

bishwasojha opened this issue Nov 4, 2022 · 5 comments · Fixed by #10529
Assignees
Labels
p3-medium Normal priority type:bug

Comments

@bishwasojha
Copy link

Pre-submission Checks

  • I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
  • I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the bug

  • The pause sync button says to terminates the syncing in dialog box. Syncing is paused. When we resumes sync, it resumes from the starting rather than from where it is paused.

Expected behavior

Pause sync button pauses the syncing and the resume sync button should resumes from where it is paused.

Steps to reproduce the issue

  1. Upload a file
  2. Click on Pause sync
  3. After sync gets paused, click on Resume sync button.
  4. Resume sync button resumes syncing from the beginning not from where it is paused.

Screenshots

Screenshot from 2022-11-04 12-04-47

Screenshot from 2022-11-04 12-04-57

Screenshot from 2022-11-04 12-05-08

Screenshot from 2022-11-04 12-10-32

Logs

ownCloud.log

Client version number

ownCloud 3.0.0.8999-daily20221104 c677c7
Libraries Qt 5.15.5, OpenSSL 1.1.1q 5 Jul 2022
Using virtual files plugin: wincfapi
windows-10.0.19044

Desktop environment (Linux only)

No response

Client package version and origin (Linux only)

No response

Installation path (Windows only)

C:\Program Files\ownCloud

Server information

ocis from docker image ocis:2.0.0-beta.8

Additional context

No response

@TheOneRing
Copy link
Contributor

@michaelstingl we should probably rename it to stop syncing?

@michaelstingl
Copy link
Contributor

michaelstingl commented Nov 4, 2022

@michaelstingl we should probably rename it to stop syncing?

Abort / cancel? Stop sounds too permanent for me.

@TheOneRing
Copy link
Contributor

It is permanent as the folder will then enter the paused state and only continue syncing once resumed.

@TheOneRing TheOneRing added this to the 4.0 milestone Nov 18, 2022
@TheOneRing
Copy link
Contributor

TODO: Rename button to "Stop synchronization"

@TheOneRing TheOneRing added the p2-high Escalation, on top of current planning, release blocker label Dec 8, 2022
@fmoc fmoc self-assigned this Dec 9, 2022
@TheOneRing TheOneRing added p3-medium Normal priority and removed p2-high Escalation, on top of current planning, release blocker labels Feb 2, 2023
@saw-jan saw-jan self-assigned this Mar 16, 2023
@saw-jan
Copy link
Member

saw-jan commented Mar 16, 2023

Tested with ownCloud 4.0.0.10422-daily20230316 8e8490

Screenshot from 2023-03-16 15-58-30 Screenshot from 2023-03-16 15-58-36
1. Separate Restart and Pause options ✔️ 2. Do you want to stop it message ✔️
Screenshot from 2023-03-16 15-58-48 Screenshot from 2023-03-16 15-58-59
3. Sync paused ✔️ 4. Resume option ✔️
Screenshot from 2023-03-16 15-59-22
5. Sync resumes - doesn't sync from beginning ✔️

@saw-jan saw-jan removed their assignment Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-medium Normal priority type:bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants