Strip user info from URL in New Connection Wizard

erikjv · erikjv · commit a1f1a1f5960d · 2024-02-16T18:38:27.000+01:00
Authentication is done through the web browser, so no user information is needed for that URL. Fixes: #11497
diff --git a/changelog/unreleased/11497 b/changelog/unreleased/11497
@@ -0,0 +1,8 @@
+Bugfix: strip user information from new-connection URL
+
+Credentials in the URL are not supported for some time. This fix strips
+them from the URL before storage and using it to authenticate the client
+to the server.
+
+https://github.com/owncloud/client/issues/11497
+https://github.com/owncloud/client/pull/11509
diff --git a/src/gui/newwizard/states/serverurlsetupwizardstate.cpp b/src/gui/newwizard/states/serverurlsetupwizardstate.cpp
@@ -72,7 +72,7 @@ void ServerUrlSetupWizardState::evaluatePage()
             userProvidedUrl.prepend(defaultUrlSchemeC);
         }
 
-        return QUrl::fromUserInput(userProvidedUrl);
+        return QUrl::fromUserInput(userProvidedUrl).adjusted(QUrl::RemoveUserInfo);
     }();
 
     // (ab)use the account builder as temporary storage for the URL we are about to probe (after sanitation)

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ void ServerUrlSetupWizardState::evaluatePage()`
`72`	`72`	`userProvidedUrl.prepend(defaultUrlSchemeC);`
`73`	`73`	`}`
`74`	`74`
`75`		`- return QUrl::fromUserInput(userProvidedUrl);`
	`75`	`+ return QUrl::fromUserInput(userProvidedUrl).adjusted(QUrl::RemoveUserInfo);`
`76`	`76`	`}();`
`77`	`77`
`78`	`78`	`// (ab)use the account builder as temporary storage for the URL we are about to probe (after sanitation)`