Fix the version string for released builds

Author: TheOneRing

changelog/unreleased/10329

@@ -0,0 +1,5 @@
+Bugfix: Fix the display of the version string for released builds
+
+We removed a trailing `-` in the version string of released clients.
+
+https://github.com/owncloud/client/pull/10329

src/common/version.cpp.in

@@ -39,3 +39,12 @@ QString OCC::Version::suffix()
 {
     return QStringLiteral("@MIRALL_VERSION_SUFFIX@");
 }
+
+QString OCC::Version::displayString()
+{
+    constexpr bool hasSuffix = !std::string_view("@MIRALL_VERSION_SUFFIX@").empty();
+    if (hasSuffix) {
+        return QStringLiteral("%1-%2").arg(versionWithBuildNumber().toString(), suffix());
+    }
+    return versionWithBuildNumber().toString();
+}

src/common/version.h

@@ -43,8 +43,5 @@ OCSYNC_EXPORT QString suffix();
  */
 OCSYNC_EXPORT QString gitSha();
 
-inline auto displayString()
-{
-    return QStringLiteral("%1-%2").arg(versionWithBuildNumber().toString(), suffix());
-}
+OCSYNC_EXPORT QString displayString();
 }