SocketAPI: Remove listener immediately on lost connection

ckamm · ckamm · commit 0bfe7ac250c5 · 2019-01-17T11:13:24.000+01:00
To avoid situations where messages are attempted to be sent to dead
connections.
diff --git a/src/gui/socketapi.cpp b/src/gui/socketapi.cpp
@@ -264,6 +264,10 @@ void SocketApi::onLostConnection()
 {
     qCInfo(lcSocketApi) << "Lost connection " << sender();
     sender()->deleteLater();
+
+    auto socket = qobject_cast<QIODevice *>(sender());
+    ASSERT(socket);
+    _listeners.erase(std::remove_if(_listeners.begin(), _listeners.end(), ListenerHasSocketPred(socket)), _listeners.end());
 }
 
 void SocketApi::slotSocketDestroyed(QObject *obj)

Original file line number	Diff line number	Diff line change
`@@ -264,6 +264,10 @@ void SocketApi::onLostConnection()`
`264`	`264`	`{`
`265`	`265`	`qCInfo(lcSocketApi) << "Lost connection " << sender();`
`266`	`266`	`sender()->deleteLater();`
	`267`	`+`
	`268`	`+ auto socket = qobject_cast<QIODevice *>(sender());`
	`269`	`+ ASSERT(socket);`
	`270`	`+ _listeners.erase(std::remove_if(_listeners.begin(), _listeners.end(), ListenerHasSocketPred(socket)), _listeners.end());`
`267`	`271`	`}`
`268`	`272`
`269`	`273`	`void SocketApi::slotSocketDestroyed(QObject *obj)`