-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/ovh_iploadbalancing_tcp_frontend: new resource #58
Conversation
hi @goblain i'm adding this new resource one major point: the refresh mechanism which is missing the farm/farm_server resources. |
will look in a moment, btw. I actually have a refresh that I use, but no tests around it (https://github.com/goblain/terraform-provider-ovh/blob/workinprogress/ovh/resource_ovh_iploadbalancing_refresh.go) |
I do not specially like the idea that resource update triggers immediate refresh within it's change logic. If we have more then one change, it will add extreme delays to the operation. As I hinted above, I would lean more to having a refresh resource that can be used after all the changes were implemented, to trigger a single reload of full new config. This also helps to avoid application of partial state to the OVH loadbalancer, as it's then called only after full state is configured.
is how I use it in my case, to trigger refresh after resources were changed |
you're abs. right then we'll try to work on your refresh resource |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few notes on first pass on my side
|
||
if err := iploadbalancingRefresh(config.OVHClient, service, resp.Zone); err != nil { | ||
return err | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as mentioned before, I would consider moving it to separate refresh resource
8a40810
to
ca14f25
Compare
thanks a lot for your review |
No description provided.