You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Taken from #3054 where it is mentioned but without details.
Today I was asked which of the two to use for implementing a new module type (in this case: root spaces).
At the very least, we should rename one, or perhaps both, because the current very similar names just lead to confusion.
IIRC AbstractAlgebra.FPModule is dense and Oscar.ModuleFP sparse (as much as one can claim such a thing for abstract types which both are -- but FPModule has a lot of "generic" code which clearly assumes something dense.
The text was updated successfully, but these errors were encountered:
While I am glad we have a workaround, clearly this is really confusing. What's the difference between free_module and FreeMod? Why do both exist? How would one find FreeMod? etc.
I think this is tightly related to FPModule vs ModuleFP, hence added it here.
Taken from #3054 where it is mentioned but without details.
Today I was asked which of the two to use for implementing a new module type (in this case: root spaces).
At the very least, we should rename one, or perhaps both, because the current very similar names just lead to confusion.
IIRC
AbstractAlgebra.FPModule
is dense andOscar.ModuleFP
sparse (as much as one can claim such a thing for abstract types which both are -- butFPModule
has a lot of "generic" code which clearly assumes something dense.The text was updated successfully, but these errors were encountered: