Fix XUnit parser softfail scenario

The test suite result works but for testcase that was not the case.
This fixes it.

Author: pdostal

lib/OpenQA/Parser/Format/XUnit.pm

@@ -70,17 +70,14 @@ sub parse {
         $ts->children('testcase')->each(
             sub {
                 my $tc = shift;
-                my $tc_result = 'ok';
-                $tc_result = 'softfail' if ($tc->{softfailures} && $tc->{softfailures} > 0);
-                $tc_result = 'fail'
-                  if ($tc->{failures} && $tc->{failures} > 0) || ($tc->{errors} && $tc->{errors} > 0);
 
                 my $text_fn = "$ts_category-$ts_name-$num";
                 $text_fn =~ s/[\/.]/_/g;
                 $text_fn .= '.txt';
                 my $content = '# Test messages ';
                 $content .= "# $tc->{name}\n" if $tc->{name};
 
+                my $tc_result = 'ok';
                 for my $out ($tc->children('skipped, passed, error, failure, softfailure')->each) {
                     if (my $res = $TC_RESULT_BY_TAG{$out->tag}) { $tc_result //= $res }
                     $content .= '# ' . $out->tag . ": \n\n";

t/30-test_parser.t

@@ -456,6 +456,7 @@ sub test_xunit_file {
     is $parser->results->search_in_details("text", qr/bacon/)->size, 16,
       'Overall 11 testsuites, 15 tests are for bacon';
     is $parser->generated_tests_output->size, 24, "23 Outputs";
+    is $parser->results->search_in_details("title", qr/bacon 14/)->size, 1, 'There is one softfailed test case';
 
     my $resultsdir = tempdir;
     $parser->write_output($resultsdir);

t/data/xunit_format_example.xml

@@ -18,9 +18,6 @@
             <testcase assertions="0" classname="bacon" name="bacon 1" time="0.001">
                 <passed message="message" type="type">inner massage</passed>
             </testcase>
-            <testcase assertions="0" classname="bacon" name="bacon 1" time="0.001">
-                <softfailure message="message" type="type">inner massage</passed>
-            </testcase>
             <testcase assertions="0" classname="bacon" name="bacon 2" time="0.001">
                 <error message="message" type="type">inner massage</error>
             </testcase>
@@ -63,9 +60,12 @@
             <testcase name="bacon 12">
                 <failure message="<b>message</b>" type="<i>type</i>"></failure>
             </testcase>
-            <testcase assertions="0" classname="not bacon" name="bacon 2" time="0.001">
+            <testcase assertions="0" classname="not bacon" name="bacon 13" time="0.001">
                 <error message="message" type="type">inner massage</error>
             </testcase>
+            <testcase assertions="0" classname="bacon" name="bacon 14" time="0.001">
+                <softfailure message="message" type="type">inner massage</softfailure>
+            </testcase>
         </testsuite>
         <!-- test suite with only one of verything -->
         <testsuite name="one thing" errors="666" tests="777" failures="888" time="0.021">