Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add test to verify GetIdentityConfidential expands everything #3217

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

alnr
Copy link
Contributor

@alnr alnr commented Apr 6, 2023

GetIdentityConfidential works like GetIdentity with ExpandEverything. This test verifies addresses are properly expanded, not just credentials.

@alnr alnr self-assigned this Apr 6, 2023
@alnr alnr requested review from aeneasr and zepatrik as code owners April 6, 2023 08:25
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #3217 (afdac85) into master (0a05d99) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head afdac85 differs from pull request most recent head 82ac8c2. Consider uploading reports for the commit 82ac8c2 to get more accurate results

@@            Coverage Diff             @@
##           master    #3217      +/-   ##
==========================================
+ Coverage   77.89%   77.91%   +0.01%     
==========================================
  Files         320      320              
  Lines       20451    20465      +14     
==========================================
+ Hits        15931    15945      +14     
  Misses       3317     3317              
  Partials     1203     1203              
Impacted Files Coverage Δ
identity/test/pool.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@alnr alnr enabled auto-merge (rebase) April 6, 2023 11:34
@aeneasr aeneasr disabled auto-merge April 6, 2023 12:50
@aeneasr aeneasr enabled auto-merge (squash) April 6, 2023 12:50
@aeneasr aeneasr merged commit f088ccd into master Apr 6, 2023
@aeneasr aeneasr deleted the test-GetIdentityConfidential branch April 6, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants