Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set proper maxAge for session cookies #3209

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

harnash
Copy link
Contributor

@harnash harnash commented Apr 3, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

This is still work in progress. I will test this out tomorrow to make sure the issue was resolved by this fix.

@harnash harnash requested review from aeneasr and zepatrik as code owners April 3, 2023 20:15
@harnash harnash mentioned this pull request Apr 3, 2023
6 tasks
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #3209 (87c1d84) into master (0cc50c6) will decrease coverage by 1.91%.
The diff coverage is n/a.

❗ Current head 87c1d84 differs from pull request most recent head f20cf9d. Consider uploading reports for the commit f20cf9d to get more accurate results

@@            Coverage Diff             @@
##           master    #3209      +/-   ##
==========================================
- Coverage   78.02%   76.12%   -1.91%     
==========================================
  Files         320      308      -12     
  Lines       20427    18874    -1553     
==========================================
- Hits        15939    14367    -1572     
- Misses       3288     3389     +101     
+ Partials     1200     1118      -82     
Impacted Files Coverage Δ
driver/registry_default.go 88.05% <ø> (+1.12%) ⬆️

... and 125 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit 1180c05 into ory:master Apr 4, 2023
@harnash harnash deleted the fix_session_cookie_lifespan branch April 4, 2023 14:52
@harnash
Copy link
Contributor Author

harnash commented Apr 4, 2023

I've tested this on our environment and fix is working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants