Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed broken docs links & code example for get verification flow #3170

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

brahmlower
Copy link
Contributor

  1. Fixes the code block example for the getVerificationFlow section of the api reference docs here: https://www.ory.sh/docs/kratos/reference/api#tag/frontend/operation/getVerificationFlow
  2. Fixes broken links to the "Ory Kratos Email and Phone Verification Documentation" page in the api reference docs.

Related issue(s)

I didn't look to see if there were any open issues for this

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation. 😁

Further Comments

@brahmlower brahmlower force-pushed the fix/docs-links-and-code-block branch from 44a0fa7 to b5be043 Compare March 16, 2023 08:00
Comment on lines 248 to 250
// res.render('verification', flow)
// res.render('verification', flow)
// })
// ```
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the change for fixing the code block (everything else is for the links)

@brahmlower brahmlower changed the title fix(docs): fixed broken docs links & code example for get verification flow fix: fixed broken docs links & code example for get verification flow Mar 16, 2023
@brahmlower brahmlower force-pushed the fix/docs-links-and-code-block branch from b5be043 to 8e53ef5 Compare March 16, 2023 08:10
@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #3170 (d15935d) into master (b9ccccf) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head d15935d differs from pull request most recent head 8e53ef5. Consider uploading reports for the commit 8e53ef5 to get more accurate results

@@            Coverage Diff             @@
##           master    #3170      +/-   ##
==========================================
- Coverage   77.71%   77.60%   -0.12%     
==========================================
  Files         317      317              
  Lines       20036    20041       +5     
==========================================
- Hits        15571    15552      -19     
- Misses       3277     3295      +18     
- Partials     1188     1194       +6     
Impacted Files Coverage Δ
selfservice/flow/verification/flow.go 92.00% <ø> (ø)
selfservice/flow/verification/handler.go 63.02% <ø> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@aeneasr aeneasr merged commit bdbddcc into ory:master Mar 16, 2023
@brahmlower brahmlower deleted the fix/docs-links-and-code-block branch March 16, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants