feat: drop unused index #3165
Merged
feat: drop unused index #3165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
previously approved these changes
Mar 13, 2023
aeneasr
reviewed
Mar 13, 2023
persistence/sql/migrations/sql/20230216142104000000_session_devices_index_drop.up.sql
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #3165 +/- ##
==========================================
+ Coverage 77.59% 77.62% +0.02%
==========================================
Files 317 317
Lines 20070 20041 -29
==========================================
- Hits 15573 15556 -17
+ Misses 3298 3292 -6
+ Partials 1199 1193 -6 see 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aeneasr
requested changes
Mar 16, 2023
| @@ -0,0 +1,3 @@ | |||
| ALTER TABLE session_devices DROP FOREIGN KEY session_devices_ibfk_2; | |||
| ALTER TABLE session_devices DROP INDEX unique_session_device; | |||
| ALTER TABLE session_devices ADD CONSTRAINT session_devices_ibfk_2 FOREIGN KEY (nid) REFERENCES networks(id); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This index doesn't serve a real purpose and is interfering with the multi-region rollout.