Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow passing transient data from registration to webhook #3104

Merged
merged 7 commits into from
Feb 21, 2023

Conversation

CaptainStandby
Copy link
Contributor

@CaptainStandby CaptainStandby commented Feb 14, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@CaptainStandby CaptainStandby force-pushed the hf/pass-transient-data-to-webhook branch from 8f38d57 to 9ac2278 Compare February 15, 2023 15:27
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #3104 (8e5a45f) into master (342bfb0) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

❗ Current head 8e5a45f differs from pull request most recent head a3c28e5. Consider uploading reports for the commit a3c28e5 to get more accurate results

@@            Coverage Diff             @@
##           master    #3104      +/-   ##
==========================================
- Coverage   77.70%   77.50%   -0.20%     
==========================================
  Files         315      314       -1     
  Lines       19963    19897      -66     
==========================================
- Hits        15512    15421      -91     
- Misses       3265     3285      +20     
- Partials     1186     1191       +5     
Impacted Files Coverage Δ
selfservice/flow/registration/flow.go 96.92% <ø> (ø)
selfservice/strategy/oidc/strategy.go 63.47% <100.00%> (+0.15%) ⬆️
selfservice/strategy/oidc/strategy_registration.go 65.40% <100.00%> (+0.44%) ⬆️
selfservice/strategy/password/registration.go 68.33% <100.00%> (+0.53%) ⬆️
selfservice/strategy/webauthn/registration.go 65.95% <100.00%> (+0.36%) ⬆️
courier/courier_dispatcher.go 43.42% <0.00%> (-25.00%) ⬇️
persistence/sql/persister_courier.go 83.33% <0.00%> (-4.77%) ⬇️
continuity/test/persistence.go

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@CaptainStandby CaptainStandby force-pushed the hf/pass-transient-data-to-webhook branch from 9ac2278 to 49f3dbd Compare February 15, 2023 17:47
@CaptainStandby CaptainStandby force-pushed the hf/pass-transient-data-to-webhook branch from 49f3dbd to d81a3d4 Compare February 17, 2023 13:40
@CaptainStandby CaptainStandby marked this pull request as ready for review February 17, 2023 18:54
@CaptainStandby CaptainStandby self-assigned this Feb 20, 2023
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks very good! I just have a few last questions.

@CaptainStandby CaptainStandby linked an issue Feb 21, 2023 that may be closed by this pull request
6 tasks
@CaptainStandby CaptainStandby merged commit 4a3a076 into master Feb 21, 2023
@CaptainStandby CaptainStandby deleted the hf/pass-transient-data-to-webhook branch February 21, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass through transient data to webhooks on registration
2 participants