Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upstream-registry-builder size seems too large #438

Closed
jmccormick2001 opened this issue Sep 10, 2020 · 4 comments · Fixed by #439
Closed

upstream-registry-builder size seems too large #438

jmccormick2001 opened this issue Sep 10, 2020 · 4 comments · Fixed by #439

Comments

@jmccormick2001
Copy link

doppio:[~] podman images | grep upstream
quay.io/operator-framework/upstream-registry-builder latest d6ecbf195274 2 days ago 1.32 GB

this seems wrong to me? am I correct or is this normally supposed to be this size.

@benluddy
Copy link
Contributor

Not sure, but it's mostly build cruft. I opened a PR (#439) to use a multi-stage build and the resulting image is about half the size.

@jmccormick2001
Copy link
Author

I might try to test that out, this image size came to my attention in an interesting way, I was trying to test something that uses this image on a CRC built Openshift instance, in crc there is some sort of image download size being enforced which causes this image to not be pulled down.

@jmccormick2001
Copy link
Author

the image size with the PR does indeed drop by over half in my testing to somewhere around 450Mb. I'd suspect people that heavily use this image will like seeing that size reduced.

@benluddy benluddy linked a pull request Sep 11, 2020 that will close this issue
@benluddy
Copy link
Contributor

Thanks for noticing and reporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants