feat(log): make termination-log setup failure non-fatal

njhale · njhale · commit 9a118c6b877b · 2019-08-15T01:03:13.000-04:00
diff --git a/cmd/configmap-server/main.go b/cmd/configmap-server/main.go
@@ -59,7 +59,7 @@ func runCmdFunc(cmd *cobra.Command, args []string) error {
 	}
 	err = log.AddDefaultWriterHooks(terminationLogPath)
 	if err != nil {
-		return err
+		logrus.WithError(err).Warn("unable to set termination log path")
 	}
 	kubeconfig, err := cmd.Flags().GetString("kubeconfig")
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ func runCmdFunc(cmd *cobra.Command, args []string) error {`
`59`	`59`	`}`
`60`	`60`	`err = log.AddDefaultWriterHooks(terminationLogPath)`
`61`	`61`	`if err != nil {`
`62`		`- return err`
	`62`	`+ logrus.WithError(err).Warn("unable to set termination log path")`
`63`	`63`	`}`
`64`	`64`	`kubeconfig, err := cmd.Flags().GetString("kubeconfig")`
`65`	`65`	`if err != nil {`