feat(opm): remove container-tool option on registry add

Remove the container-tool option on opm registry add in favor of exclusively pulling bundle images with the unprivileged implementation.

Author: njhale

cmd/opm/registry/add.go

@@ -27,7 +27,6 @@ func newRegistryAddCmd() *cobra.Command {
 	rootCmd.Flags().StringP("database", "d", "bundles.db", "relative path to database file")
 	rootCmd.Flags().StringSliceP("bundle-images", "b", []string{}, "comma separated list of links to bundle image")
 	rootCmd.Flags().Bool("permissive", false, "allow registry load errors")
-	rootCmd.Flags().StringP("container-tool", "c", "podman", "tool to interact with container images (save, build, etc.). One of: [docker, podman, unprivileged]")
 
 	return rootCmd
 }
@@ -47,16 +46,10 @@ func addFunc(cmd *cobra.Command, args []string) error {
 		return err
 	}
 
-	containerTool, err := cmd.Flags().GetString("container-tool")
-	if err != nil {
-		return err
-	}
-
 	request := registry.AddToRegistryRequest{
 		Bundles:       bundleImages,
 		InputDatabase: fromFilename,
 		Permissive:    permissive,
-		ContainerTool: containerTool,
 	}
 
 	logger := logrus.WithFields(logrus.Fields{"bundles": bundleImages})

go.mod

@@ -10,7 +10,6 @@ require (
 	github.com/docker/distribution v2.7.1+incompatible
 	github.com/docker/go-events v0.0.0-20190806004212-e31b211e4f1c // indirect
 	github.com/ghodss/yaml v1.0.0
-	github.com/gogo/googleapis v1.3.2 // indirect
 	github.com/golang-migrate/migrate/v4 v4.6.2
 	github.com/golang/mock v1.3.1
 	github.com/golang/protobuf v1.3.2
@@ -22,11 +21,13 @@ require (
 	github.com/opencontainers/image-spec v1.0.1
 	github.com/operator-framework/api v0.1.1
 	github.com/otiai10/copy v1.0.2
+	github.com/phayes/freeport v0.0.0-20180830031419-95f893ade6f2
 	github.com/pkg/errors v0.9.1
 	github.com/sirupsen/logrus v1.4.2
 	github.com/spf13/cobra v0.0.5
 	github.com/stretchr/testify v1.4.0
 	go.etcd.io/bbolt v1.3.3
+	golang.org/x/mod v0.2.0
 	golang.org/x/net v0.0.0-20191028085509-fe3aa8a45271
 	golang.org/x/oauth2 v0.0.0-20190604053449-0f29369cfe45
 	google.golang.org/grpc v1.27.0
@@ -37,5 +38,6 @@ require (
 	k8s.io/client-go v0.17.3
 	k8s.io/klog v1.0.0
 	k8s.io/kubectl v0.17.3
-	rsc.io/letsencrypt v0.0.3 // indirect
 )
+
+replace github.com/docker/distribution => github.com/docker/distribution v0.0.0-20191216044856-a8371794149d