Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.11: pod with sysctl example needs to be updated #10225

Closed
php-coder opened this issue Jun 19, 2018 · 4 comments
Closed

3.11: pod with sysctl example needs to be updated #10225

php-coder opened this issue Jun 19, 2018 · 4 comments
Assignees

Comments

@php-coder
Copy link

Which section is the issue in?

https://docs.openshift.org/latest/admin_guide/sysctls.html#setting-sysctls-for-a-pod

What needs fixing?

OpenShift 3.11 that will be on top of Kubernetes 1.11 won't work with the old sysctl annotations that are present in our example. The example will require an update, like Kubernetes did: https://github.com/kubernetes/website/pull/8804/files#diff-bbdf255eebe738c7c70b93ea3ddcde37L119

@ingvagabund Is this a task for pod team?

CC @kalexand-rh

@ingvagabund
Copy link
Member

@php-coder should be basically copy-paste with slight modifications to accommodate the OpenShift docs style

@ingvagabund
Copy link
Member

so anyone can do that, we can do the review

@kalexand-rh
Copy link
Contributor

I made a PR for this change here: #10361

@vikram-redhat
Copy link
Contributor

Since this is being tracked via #10361 I am closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants