Skip to content

Commit e92d8bc

Browse files
authoredJun 20, 2023
fix(sdk): fix GitHub release script (kubeflow#9663)
1 parent 0f8d6d2 commit e92d8bc

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed
 

‎sdk/hack/github_release.sh

+6-5
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,13 @@
1818
# finish the process using the GitHub UI to publish the draft
1919

2020
# example usage:
21-
# > ./sdk/hack/github_release.sh 1.8.13
21+
# > ./sdk/hack/github_release.sh 2.0.0
2222

2323
set -ex
2424

25-
# Prefix tag name with `sdk-` to distinguish from runtime releases
26-
TAG_NAME="sdk-$1"
25+
# Prefix tag name with `sdk-` to distinguish from runtime releases
26+
TARGET_VERSION=$1
27+
TAG_NAME="sdk-$TARGET_VERSION"
2728
TARGET_HASH=$(git rev-parse HEAD)
2829

2930
# substrings indicating pre-release status
@@ -38,9 +39,9 @@ else
3839
fi
3940

4041

41-
TITLE="KFP SDK v${TAG_NAME}"
42+
TITLE="KFP SDK v${TARGET_VERSION}"
4243
RELEASE_NOTES_LINK="https://github.com/kubeflow/pipelines/blob/${TARGET_HASH}/sdk/RELEASE.md"
4344
REPO=kubeflow/pipelines
44-
NOTES="Release of the KFP SDK **only**."$'\n'$'\n'"To install the KFP SDK:"$'\n'"\`\`\`bash"$'\n'"pip install kfp==${TAG_NAME}"$'\n'"\`\`\`"$'\n'"For changelog, see [release notes](${RELEASE_NOTES_LINK})."
45+
NOTES="Release of the KFP SDK **only**."$'\n'$'\n'"To install the KFP SDK:"$'\n'"\`\`\`bash"$'\n'"pip install kfp==${TARGET_VERSION}"$'\n'"\`\`\`"$'\n'"For changelog, see [release notes](${RELEASE_NOTES_LINK})."
4546

4647
gh release create $TAG_NAME --target $TARGET_HASH --repo $REPO --title "${TITLE}" --notes "${NOTES}" $PRE_STATUS --draft

0 commit comments

Comments
 (0)
Please sign in to comment.