Skip to content

Commit 7838009

Browse files
authoredFeb 28, 2025
feat(sdk): Add Input Parameter support for configmap, secrets, node selectors, tolerations, pull secrets (kubeflow#11621)
This change adds the necessary proto changes to accomodate parameterized input for various k8s platform fields: secrets, configmaps, node selectors, tolerations, and image pull secrets. Signed-off-by: Humair Khan <[email protected]>
1 parent 13b8194 commit 7838009

File tree

8 files changed

+696
-565
lines changed

8 files changed

+696
-565
lines changed
 

‎.github/workflows/validate-generated-files.yml

+8-1
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,20 @@
11
name: Validate Generated Files
22
on:
3+
push:
4+
branches:
5+
- master
36
pull_request:
47
paths:
5-
- 'backend/api/**/*.proto'
68
- '.github/workflows/validate-generated-files.yml'
9+
- 'backend/api/**/*.proto'
710
- 'backend/api/**/go_http_client/**'
811
- 'backend/api/**/go_client/**'
912
- 'backend/api/**/python_http_client/**'
1013
- 'backend/api/**/swagger/**'
14+
- 'api/**/*.proto'
15+
- 'api/**/*.go'
16+
- 'kubernetes_platform/**/*.proto'
17+
- 'kubernetes_platform/**/*.go'
1118

1219
jobs:
1320
validate-generated-files:

‎api/v2alpha1/go/pipelinespec/pipeline_spec.pb.go

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎api/v2alpha1/pipeline_spec.proto

+3-3
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ message TaskInputsSpec {
292292

293293
// Represents an input parameter. The value can be taken from an upstream
294294
// task's output parameter (if specifying `producer_task` and
295-
// `output_parameter_key`, or it can be a runtime value, which can either be
295+
// `output_parameter_key`), or it can be a runtime value, which can either be
296296
// determined at compile-time, or from a pipeline parameter.
297297
message InputParameterSpec {
298298
// Represents an upstream task's output parameter.
@@ -307,9 +307,9 @@ message TaskInputsSpec {
307307

308308
// Represents an upstream task's final status. The field can only be set if
309309
// the schema version is `2.0.0`. The resolved input parameter will be a
310-
// json payload in string type.
310+
// JSON payload in string type.
311311
message TaskFinalStatus {
312-
// The name of the upsteram task where the final status is coming from.
312+
// The name of the upstream task where the final status is coming from.
313313
string producer_task = 1;
314314
}
315315

‎kubernetes_platform/Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ clean-python:
6060
.PHONY: generate-go-in-container
6161
generate-go-in-container:
6262
mkdir -p go/kubernetesplatform
63-
cd proto && protoc -I=. \
63+
cd proto && protoc -I=. -I=../../api/v2alpha1 \
6464
--go_out=../go/kubernetesplatform \
6565
--go_opt=paths=source_relative \
6666
kubernetes_executor_config.proto

0 commit comments

Comments
 (0)
Please sign in to comment.