Merge pull request #21 from dsrhub/zz/change-to-apply-dd-at-router

zhouzhuojie · web-flow · commit a79b0b8b211e · 2020-07-15T14:10:32.000-07:00
Change to apply dd at router layer
diff --git a/init/dsrhub_init_plugin/metric.go b/init/dsrhub_init_plugin/metric.go
@@ -24,10 +24,7 @@ func (p *DSRHubInitPlugin) setupMetrics() error {
 		tracer.WithService(p.StatsdAPMServiceName),
 	)
 
-	ginEngine := router.Engine()
-	ginEngine.Use(gintrace.Middleware(
-		fmt.Sprintf("%s-http-server", p.StatsdAPMServiceName),
-	))
+	router.Use(gintrace.Middleware(fmt.Sprintf("%s-http-server", p.StatsdAPMServiceName)))
 
 	return nil
 }

Original file line number	Diff line number	Diff line change
`@@ -24,10 +24,7 @@ func (p *DSRHubInitPlugin) setupMetrics() error {`
`24`	`24`	`tracer.WithService(p.StatsdAPMServiceName),`
`25`	`25`	`)`
`26`	`26`
`27`		`- ginEngine := router.Engine()`
`28`		`- ginEngine.Use(gintrace.Middleware(`
`29`		`- fmt.Sprintf("%s-http-server", p.StatsdAPMServiceName),`
`30`		`- ))`
	`27`	`+ router.Use(gintrace.Middleware(fmt.Sprintf("%s-http-server", p.StatsdAPMServiceName)))`
`31`	`28`
`32`	`29`	`return nil`
`33`	`30`	`}`