Q appears to not work properly (?)

[somebody1234]

Steps to reproduce:

1. Open oni
2. Press <S-Q>
3. Type :c
4. Type anything

Result: output is inserted into current buffer when enter is pressed, but command popup never disappears

[somebody1234]

The command popup appears to not work at all (but still contain : after enter is pressed) when text is entered into the buffer before <S-Q> is pressed

[justinmk]

what version of Nvim? does gQ work?

[somebody1234]

Neovim 0.3.3, gQ produces the same results

[justinmk]

I would not expect oni2 to work well with 0.3.x, try 0.4.

[somebody1234]

@justinmk how would you do that? 🤔 seems like 0.3.3 is hardcoded in

[justinmk]

Then I guess that's not the problem. I thought it could be related to ext_messages feature which requires 0.4

[CrossR]

Result: output is inserted into current buffer when enter is pressed, but command popup never disappears

Am I missing something, or is that not the same behaviour as terminal neovim?
Pressing Q in neovim I enter Ex mode, so pressing c then anything else I start to type that into the command line ex mode.

That is, if I do Qc<CR> then a<CR>b<CR>c<CR>.<CR>visual<CR> I drop back to normal mode with no popup as I would expect and the expected added lines.

There is a few other issues around this though:

• The first letter seems to not show up when done in an empty buffer.
• When leaving Ex mode, control doesn't seem to return to the user, again only in an empty buffer. You are stuck unable to move, but still able to enter commands.
• Currently there is no message of "Entered Ex mode, type visual to leave" (Though I think that will be covered by Feature/externalised messages #280).
• Syntax highlighting doesn't seem too happy when I do this in a normal file (a json file was tested) it seems to break the subsequent highlights until I edit the code.

Its also not great UI/UX for the user, with both the different style of input and the missing message.

seems like 0.3.3 is hardcoded in

Currently we vendor neovim into Oni2, to prevent so many of the issues we had of people using older versions and stuff breaking or not launching. Right now that is 0.3.3 but #280 bumps that to 0.4 for ext_messages.